router: return error when registering nil handler#2815
Open
Narita-1095305 wants to merge 1 commit intolabstack:masterfrom
Open
router: return error when registering nil handler#2815Narita-1095305 wants to merge 1 commit intolabstack:masterfrom
Narita-1095305 wants to merge 1 commit intolabstack:masterfrom
Conversation
…nst nil handler; tests: add panic assertions for nil handler registration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
router.insertonly logs a warning when a nil handler is registered,and continues processing. This can lead to runtime panics due to unnoticed misconfiguration.
This change makes router registration fail fast by returning an error
when a nil handler is provided, so that misconfigurations can be detected earlier.